Upgrade simplejson to 3.18.4
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpark-hrp
commented
Mar 17, 2024
| class TestException(Exception): | ||
| pass | ||
|
|
||
| expected_app_root = "/tmp/test/app_root" | ||
| expected_handler = "app.my_test_handler" | ||
| expected_lambda_runtime_api_addr = "test_addr" | ||
|
|
||
| mock_build_fault_result.return_value = {} |
There was a problem hiding this comment.
We need to mock build_fault_result() return value because newer simplejson will throw an error when it tries to JSON encode a MagicMock type.
E TypeError: _asdict() must return a dict, not MagicMock
aws-lambda-python-runtime-interface-client/awslambdaric/bootstrap.py
Lines 485 to 488 in 056aa36
|
@briensea @alex-pewpew @pushkarchawda @andclt |
|
LGTM |
alex-pewpew
approved these changes
Mar 27, 2024
briensea
approved these changes
Mar 27, 2024
|
Thanks for contributing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
fixes #135
fixes #93
fixes #62
Description of changes:
simplejson==3.18.4Testing
make pr make test make test-smoke make test-integTarget (OCI, Managed Runtime, both):
Both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.